Conversation
|
@labkey-jeckels there are a couple other places that should be updated ( |
Updated. I also eliminated |
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
I think I'm not fully understanding how the ConnectionState and Cleaner work since JavaDocs say the state should have no reference to the object being cleaned, but then I'm not sure how it can be used to clean anything.
In any case, I think the || true hacks want removing.
| private final StackTraceElement[] _debugCreated; | ||
| private final @Nullable DbScope _scope; | ||
| private final @Nullable Connection _connection; | ||
| private final ResultSet _rs; // This is the underlying result set |
There was a problem hiding this comment.
Is this OK? I thought the state was not supposed to have a reference to the object being cleaned?
There was a problem hiding this comment.
I think we're OK. The ResultSetImpl is the thing being cleaned. This member variable is the ResultSet that's being wrapped. See the use of rs in the call to the ResultSetState constructor vs this being passed to the cleaner on the next line.
These can be confusing and easy to mess up, so let me know what you think of my explanation.
4 participants
Rationale
We're upgrading to require Java 25.
Changes